[igt-dev] [PATCH i-g-t] Allow a full modeset in kms_properties atomic case

James Ausmus james.ausmus at intel.com
Fri Dec 7 16:11:53 UTC 2018


On Wed, Nov 28, 2018 at 02:56:03PM +0100, Maarten Lankhorst wrote:
> Op 28-11-18 om 14:03 schreef Stanislav Lisovskiy:
> > Otherwise we are getting EINVAL as drm requires it
> > at some point.
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108642
> > Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy at intel.com>
> > ---
> >  tests/kms_properties.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tests/kms_properties.c b/tests/kms_properties.c
> > index 82d28e9b..eb9cbdda 100644
> > --- a/tests/kms_properties.c
> > +++ b/tests/kms_properties.c
> > @@ -100,7 +100,7 @@ static void max_bpc_prop_test(int fd, uint32_t id, uint32_t type, drmModePropert
> >  			ret = drmModeAtomicAddProperty(req, id, prop_id, i);
> >  			igt_assert(ret >= 0);
> >  
> > -			ret = drmModeAtomicCommit(fd, req, DRM_MODE_ATOMIC_TEST_ONLY, NULL);
> > +			ret = drmModeAtomicCommit(fd, req, DRM_MODE_ATOMIC_TEST_ONLY | DRM_MODE_ATOMIC_ALLOW_MODESET, NULL);
> >  			igt_assert_eq(ret, 0);
> >  		}
> >  	}
> 
> Reviewed-by: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
> 
> Lets wait for CI results before committing it. :)

Can this get merged now, or is it still waiting for something
additional?

Thanks!

-James

> 
> _______________________________________________
> igt-dev mailing list
> igt-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev


More information about the igt-dev mailing list