[igt-dev] [PATCH i-g-t 2/2] tests/perf: polling: fix uninitialized start_times

Lionel Landwerlin lionel.g.landwerlin at intel.com
Fri Dec 14 13:30:52 UTC 2018


On 14/12/2018 11:58, Matthew Auld wrote:
> On Tue, 11 Dec 2018 at 18:06, Lionel Landwerlin
> <lionel.g.landwerlin at intel.com> wrote:
>> Not quite sure how that fell through the cracks for so long...
>>
>> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102252
> It looks like we initialize it earlier :)


I can't see where :|

Unless it's in the test_blocking() which is a different test.


>
>> ---
>>   tests/perf.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/tests/perf.c b/tests/perf.c
>> index 220c52ef..54e7f4f4 100644
>> --- a/tests/perf.c
>> +++ b/tests/perf.c
>> @@ -2230,6 +2230,7 @@ test_polling(void)
>>           * the error delta.
>>           */
>>          start = get_time();
>> +       times(&start_times);
>>          do_ioctl(stream_fd, I915_PERF_IOCTL_ENABLE, 0);
>>          for (/* nop */; ((end = get_time()) - start) < test_duration_ns; /* nop */) {
>>                  struct pollfd pollfd = { .fd = stream_fd, .events = POLLIN };
>> --
>> 2.20.0.rc2
>>
>> _______________________________________________
>> igt-dev mailing list
>> igt-dev at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/igt-dev




More information about the igt-dev mailing list