[igt-dev] [PATCH i-g-t] tests/perf: fix report validity check on gen10+

Lionel Landwerlin lionel.g.landwerlin at intel.com
Thu Feb 1 15:20:46 UTC 2018


On 31/01/18 20:04, Matthew Auld wrote:
> On 29 January 2018 at 12:03, Lionel Landwerlin
> <lionel.g.landwerlin at intel.com> wrote:
>> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
>> Testcase: igt/perf/buffer-fill & igt/perf/enable-disable & igt/perf/gen8-unprivileged-single-ctx-counters
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104658
>> ---
>>   tests/perf.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tests/perf.c b/tests/perf.c
>> index a173680c..55d6e9ea 100644
>> --- a/tests/perf.c
>> +++ b/tests/perf.c
>> @@ -473,7 +473,7 @@ oa_report_ctx_is_valid(uint32_t *report)
>>                  return false; /* TODO */
>>          } else if (IS_GEN8(devid)) {
>>                  return report[0] & (1ul << 25);
>> -       } else if (IS_GEN9(devid)) {
>> +       } else if (AT_LEAST_GEN(devid, 9)) {
>>                  return report[0] & (1ul << 16);
>>          }
> Do we want to drop the !"reached", since this is now very much a catch all?
>
> Anyway:
> Reviewed-by: Matthew Auld <matthew.auld at intel.com>
>
Thanks Matt, decided to leave that assert for now.


More information about the igt-dev mailing list