[igt-dev] [PATCH i-g-t] lib: Move __gem_context_create to common ioctl wrapper library.

Chris Wilson chris at chris-wilson.co.uk
Fri Feb 2 21:10:57 UTC 2018


Quoting Antonio Argenziano (2018-02-02 18:25:54)
>  /**
>   * gem_context_create:
>   * @fd: open i915 drm file descriptor
> @@ -55,18 +101,13 @@
>   */
>  uint32_t gem_context_create(int fd)
>  {
> -       struct drm_i915_gem_context_create create;
> +       uint32_t ctx_id;
> +       gem_require_contexts(fd);

Spoilsport. Remember a newline after the variable block.

So having seen gem_has_contexts() split out I was hoping that all
context users would start requiring contexts themselves rather than have
this obnoxious requirement spam.

Fwiw, I much prefer igt_require(gem_has_contexts()) in the
fixtures/tests than gem_require_contexts(), just for the localisation
in the message.

Still this patch doesn't make anything worse, but it appears to missing
all the queues and other shared contexts... :-p
-Chris


More information about the igt-dev mailing list