[igt-dev] [PATCH i-g-t] igt/gem_exec_fence: Skip parallel* tests if I915_PARAM_HAS_EXEC_SUBMIT_FENCE is not defined

Chris Wilson chris at chris-wilson.co.uk
Wed Feb 14 21:39:23 UTC 2018


Quoting Antonio Argenziano (2018-02-14 21:34:24)
> Have has_submit_fence return false if the paramter it is looking for is
> not defined.
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104284
> Signed-off-by: Antonio Argenziano <antonio.argenziano at intel.com>
> 
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> ---
>  tests/gem_exec_fence.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/gem_exec_fence.c b/tests/gem_exec_fence.c
> index bd7b1263..60410e70 100644
> --- a/tests/gem_exec_fence.c
> +++ b/tests/gem_exec_fence.c
> @@ -694,17 +694,21 @@ static void test_fence_flip(int i915)
>  
>  static bool has_submit_fence(int fd)
>  {

No, this has to be defined in this test to run against kernels before it
hits the headers. Which is why we use local defines in the first place.

> +#ifndef I915_PARAM_HAS_EXEC_SUBMIT_FENCE
> +       return false;
> +#else
>         struct drm_i915_getparam gp;
>         int value = 0;
>  
>         memset(&gp, 0, sizeof(gp));
> -       gp.param = 50; /* I915_PARAM_HAS_EXEC_SUBMIT_FENCE */
> +       gp.param = I915_PARAM_HAS_EXEC_SUBMIT_FENCE;

My patches did WIP ^ HASOEXEC_SUBMIT_FENCE.
-Chris


More information about the igt-dev mailing list