[igt-dev] [PATCH i-g-t] test/perf: fixup inverted condition

Lionel Landwerlin lionel.g.landwerlin at intel.com
Thu Feb 22 01:41:52 UTC 2018


The previous patch said :

"verify that the time is always longer or equal to the period we've
 asked for"

This is an obvious error, it only worked on my machine and the CI
because only one longer period was observed. But another CI run caught
the issue :

  https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4280/shard-glkb6/igt@perf@oa-exponents.html

Fixes: c3d11ca104fa ("tests/perf: make oa-exponents subtest more reliable")
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
---
 tests/perf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/perf.c b/tests/perf.c
index 05108f5a..c302a355 100644
--- a/tests/perf.c
+++ b/tests/perf.c
@@ -1795,7 +1795,7 @@ test_oa_exponents(void)
 				  oa_report_get_ctx_id(timer_reports[i].report),
 				  delta, delta == expected_timestamp_delta ? "" : "******");
 
-			matches += expected_timestamp_delta >= delta;
+			matches += expected_timestamp_delta <= delta;
 		}
 
 		igt_debug("matches=%u/%u\n", matches, n_timer_reports - 1);
-- 
2.16.1



More information about the igt-dev mailing list