[igt-dev] [PATCH i-g-t v2 1/3] igt/kms_fbcon_fbt: Handle ENODEV when checking i915_edp_psr_status for chipset support

[Lofstedt, Marta]

Thanks Chris, sorry for ripping off your work!

> -----Original Message-----
> From: Chris Wilson [mailto:chris at chris-wilson.co.uk]
> Sent: Thursday, February 22, 2018 10:02 AM
> To: Lofstedt, Marta <marta.lofstedt at intel.com>; igt-
> dev at lists.freedesktop.org
> Subject: Re: [igt-dev] [PATCH i-g-t v2 1/3] igt/kms_fbcon_fbt: Handle
> ENODEV when checking i915_edp_psr_status for chipset support
> 
> Quoting Marta Lofstedt (2018-02-22 08:00:10)
> > If the machine doesn't support PSR, it will return -ENODEV from
> > i915_edp_psr_status, which we want to interpret as unsupported.
> > This is in line with what Chris just fixed for FBC.
> >
> > V2: Copy-pasted to the correct position.
> >
> > Signed-off-by: Marta Lofstedt <marta.lofstedt at intel.com>
> > ---
> >  tests/kms_fbcon_fbt.c | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/tests/kms_fbcon_fbt.c b/tests/kms_fbcon_fbt.c index
> > 1b236f8b..b01c769c 100644
> > --- a/tests/kms_fbcon_fbt.c
> > +++ b/tests/kms_fbcon_fbt.c
> > @@ -165,6 +165,9 @@ static bool psr_supported_on_chipset(int fd)
> >         char buf[256];
> >
> >         igt_debugfs_read(fd, "i915_edp_psr_status", buf);
> > +       if (*buf == '\0') /* !HAS_PSR -> -ENODEV*/
> > +               return false;
> 
> Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk> -Chris