[igt-dev] [PATCH] [CI] kernel: Downgrade warning for unsafe parameters

Jani Nikula jani.nikula at linux.intel.com
Mon Feb 26 10:42:40 UTC 2018


On Tue, 20 Feb 2018, Chris Wilson <chris at chris-wilson.co.uk> wrote:
> We make use of unsafe kernel parameters in igt, which generates a
> warning and taints the kernel. The warning is unhelpful as we then need
> to filter it out again, so kill it at source.

Is your goal to upstream this or what?

BR,
Jani.

>
> Cc: Petri Latvala <petri.latvala at intel.com>
> Cc: Daniel Vetter <daniel.vetter at ffwll.ch>
> ---
>  kernel/params.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/params.c b/kernel/params.c
> index cc9108c2a1fd..ce89f757e6da 100644
> --- a/kernel/params.c
> +++ b/kernel/params.c
> @@ -111,8 +111,8 @@ bool parameq(const char *a, const char *b)
>  static void param_check_unsafe(const struct kernel_param *kp)
>  {
>  	if (kp->flags & KERNEL_PARAM_FL_UNSAFE) {
> -		pr_warn("Setting dangerous option %s - tainting kernel\n",
> -			kp->name);
> +		pr_notice("Setting dangerous option %s - tainting kernel\n",
> +			  kp->name);
>  		add_taint(TAINT_USER, LOCKDEP_STILL_OK);
>  	}
>  }

-- 
Jani Nikula, Intel Open Source Technology Center


More information about the igt-dev mailing list