[igt-dev] [PATCH i-g-t] igt/gem_measure_ring_size_inflight: Measure smallest inflight ring size

Chris Wilson chris at chris-wilson.co.uk
Mon Feb 26 22:56:22 UTC 2018


Quoting Antonio Argenziano (2018-02-26 22:41:27)
> diff --git a/lib/i915/gem_ring.h b/lib/i915/gem_ring.h
> index c69adce0..9fbce59e 100644
> --- a/lib/i915/gem_ring.h
> +++ b/lib/i915/gem_ring.h
> @@ -30,6 +30,9 @@ enum measure_ring_flags {
>         MEASURE_RING_NEW_CTX = 1
>  };
>  
> +unsigned int
> +__gem_measure_ring_inflight(int fd, unsigned int engine, enum measure_ring_flags flags);

Are you planning to measure the number of batches that can be sent to an
invalid engine, or something? Without a user, adding redundant API seems
overengineering.

Also on the agenda what to call gem_measure_inflight_contexts()?
gem_measure_contexts_inflight? Nah, should have called this
gem_measure_inflight_batches.
-Chris


More information about the igt-dev mailing list