[igt-dev] [PATCH i-g-t 3/4] meson: Add quotes in assembler/test/run-test.sh

Petri Latvala petri.latvala at intel.com
Tue Jan 16 11:13:05 UTC 2018


If the directories contain spaces, run-test.sh fails.

Signed-off-by: Petri Latvala <petri.latvala at intel.com>
---
 assembler/test/run-test.sh | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/assembler/test/run-test.sh b/assembler/test/run-test.sh
index b06e1044..f5e1a8fb 100644
--- a/assembler/test/run-test.sh
+++ b/assembler/test/run-test.sh
@@ -1,7 +1,7 @@
 #!/bin/sh
 
-SRCDIR=${srcdir-`pwd`}
-BUILDDIR=${top_builddir-`pwd`}
+SRCDIR="${srcdir-`pwd`}"
+BUILDDIR="${top_builddir-`pwd`}"
 
 test="TEST"
 
@@ -9,11 +9,11 @@ if [ -n "$1" ] ; then
 	test="$1"
 fi
 
-test -d ${BUILDDIR}/test || mkdir ${BUILDDIR}/test/
+test -d "${BUILDDIR}/test" || mkdir "${BUILDDIR}/test/"
 
-${BUILDDIR}/intel-gen4asm -o ${BUILDDIR}/${test}.out $SRCDIR/${test}.g4a
-if cmp ${BUILDDIR}/${test}.out ${SRCDIR}/${test}.expected 2> /dev/null; then : ; else
+"${BUILDDIR}/intel-gen4asm" -o "${BUILDDIR}/${test}.out" "$SRCDIR/${test}.g4a"
+if cmp "${BUILDDIR}/${test}.out" "${SRCDIR}/${test}.expected" 2> /dev/null; then : ; else
   echo "Output comparison for ${test}"
-  diff -u ${SRCDIR}/${test}.expected ${test}.out
+  diff -u "${SRCDIR}/${test}.expected" "${test}.out"
   exit 1;
 fi
-- 
2.14.1



More information about the igt-dev mailing list