[igt-dev] [PATCH i-g-t 1/5] doc: Fix typos in CONTRIBUTING

[Petri Latvala]

On Wed, Jan 17, 2018 at 12:23:33AM -0500, Rhys Kidd wrote:
> Signed-off-by: Rhys Kidd <rhyskidd at gmail.com>
> ---
> Note this partially overlaps with an in flight patch from Sean Paul. Carrying
> the same patch in my local tree for now.

Sean Paul's patch is now merged.


> 
>  CONTRIBUTING | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/CONTRIBUTING b/CONTRIBUTING
> index 2e746c73..991dacc6 100644
> --- a/CONTRIBUTING
> +++ b/CONTRIBUTING
> @@ -18,7 +18,7 @@ A short list of contribution guidelines:
>  
>    on its first invocation.
>  
> -- intel-gpu-tools is MIT lincensed and we require contributions to follow the
> +- intel-gpu-tools is MIT licensed and we require contributions to follow the
>    developer's certificate of origin: http://developercertificate.org/

As seen above, this chunk is already in.


>  - When submitting new testcases please follow the naming conventions documented
> @@ -29,7 +29,7 @@ A short list of contribution guidelines:
>  - Patches need to be reviewed on the mailing list. Exceptions only apply for
>    testcases and tooling for drivers with just a single contributor (e.g. vc4).
>    In this case patches must still be submitted to the mailing list first.
> -  Testcase should preferrably be cross-reviewed by the same people who write and
> +  Testcase should preferably be cross-reviewed by the same people who write and
>    review the kernel feature itself.

This chunk is good.



> @@ -38,7 +38,7 @@ A short list of contribution guidelines:
>    contact one of the maintainers (listed in the MAINTAINERS file) and cc the
>    intel-gfx mailing list.
>  
> -- Especially changes to the testcase should get tested on relevant platforms
> +- Especially changes to the testcases should get tested on relevant platforms
>    before committing. For Intel employees that's best done using PRTS, see the
>    relevant internal howtos. Everyone else can just run piglit with i-g-t tests
>    locally.


This whole paragraph doesn't make much sense anymore. We now run CI
for IGT patches so they automatically get tested. Perhaps changing the
whole thing to:

 - Changes to the testcases are automatically tested. Take the results
   into account before merging.



-- 
Petri Latvala