[igt-dev] [PATCH igt] igt/pm_rps: Include related kernel RPS info

Petri Latvala petri.latvala at intel.com
Mon Jan 22 10:54:11 UTC 2018


On Fri, Jan 19, 2018 at 01:35:12PM +0000, Chris Wilson wrote:
> Dump i915_rps_boost_info for debug assertion failures, as that contains
> all the pertinent information the kernel has for RPS tuning.
> 
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>

Note to self: Make igt_debugfs_dump print something else than just
<whatever glibc prints for NULL> when the file does not exist...

Reviewed-by: Petri Latvala <petri.latvala at intel.com>


> ---
>  tests/pm_rps.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/tests/pm_rps.c b/tests/pm_rps.c
> index 8dd73917b..f71976ed0 100644
> --- a/tests/pm_rps.c
> +++ b/tests/pm_rps.c
> @@ -434,6 +434,7 @@ static void idle_check(void)
>  		wait += IDLE_WAIT_TIMESTEP_MSEC;
>  	} while (wait < IDLE_WAIT_TIMEOUT_MSEC);
>  
> +	igt_debugfs_dump(drm_fd, "i915_rps_boost_info");
>  	igt_assert_eq(freqs[CUR], freqs[RPn]);
>  	igt_debug("Required %d msec to reach cur=idle\n", wait);
>  }
> @@ -457,6 +458,7 @@ static void loaded_check(void)
>  		wait += LOADED_WAIT_TIMESTEP_MSEC;
>  	} while (wait < LOADED_WAIT_TIMEOUT_MSEC);
>  
> +	igt_debugfs_dump(drm_fd, "i915_rps_boost_info");
>  	igt_assert_lte(freqs[MAX], freqs[CUR]);
>  	igt_debug("Required %d msec to reach cur=max\n", wait);
>  }
> @@ -484,6 +486,7 @@ static void stabilize_check(int *out)
>  		wait += STABILIZE_WAIT_TIMESTEP_MSEC;
>  	} while (wait < STABILIZE_WAIT_TIMEOUT_MSEC);
>  
> +	igt_debugfs_dump(drm_fd, "i915_rps_boost_info");
>  	igt_debug("Waited %d msec to stabilize cur\n", wait);
>  }
>  
> -- 
> 2.15.1
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev


More information about the igt-dev mailing list