[igt-dev] [PATCH i-g-t] gem_gpu_fill: Merging gem_gpgpu_fill and gem_media_fill into one

Chris Wilson chris at chris-wilson.co.uk
Mon Jan 29 12:52:42 UTC 2018


Quoting Kalamarz, Lukasz (2018-01-29 12:18:27)
> On Fri, 2018-01-26 at 15:14 +0000, Chris Wilson wrote:
> > Quoting Lukasz Kalamarz (2018-01-26 15:03:02)
> > > Implementation of those test only differ with fill_function used by
> > > either media or gpgpu pipeline, which shared same type. Rather than
> > > having two tests, which are in 98% copy-paste it is easier to
> > > maintain one with same functionality.
> > 
> > I hear there's a render equivalent as well.
> > I presume each routine is run over all engines that support it?
> 
> There is similar test (gem_render_copy) with slightly different
> semantics and it is using other struct to perform operation
> (igt_fillfunc_t vs igt_copy_function_t).
> We can implement render_fill_func using render blit. Is that what You
> have in mind? 

Yes.

> Each routine is run over all engines (meaning the only engine that
> supports it - render).

Hmm, I thought mediafill was vcs. If not, we are lacking an exerciser.
Whether or not that is important is another question.
-Chris


More information about the igt-dev mailing list