[igt-dev] [PATCH i-g-t] igt/gem_exec_params: Drop drm master privileges only on drm master fds

Chris Wilson chris at chris-wilson.co.uk
Wed Jan 31 21:07:33 UTC 2018


Quoting Chris Wilson (2018-01-31 20:52:45)
> Quoting Antonio Argenziano (2018-01-31 19:39:01)
> > Subtest 'secure-non-master' tries to drop drm-master privileges on a
> > non drm-master fd. Instead drop master privileges after the subtest
> > acquires it so that other subtests are not affected by it.
> > 
> > Signed-off-by: Antonio Argenziano <antonio.argenziano at intel.com>
> > Cc: Chris Wilson <chris at chris-wilson.co.uk>
> > Cc: Daniel Vetter <daniel.vetter at ffwll.ch>
> > Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
> > ---
> >  tests/gem_exec_params.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/tests/gem_exec_params.c b/tests/gem_exec_params.c
> > index e1c48b40..dbd89e7c 100644
> > --- a/tests/gem_exec_params.c
> > +++ b/tests/gem_exec_params.c
> > @@ -343,13 +343,13 @@ igt_main
> >         }
> >  
> >         igt_subtest("secure-non-master") {
> 
> igt_require(iamroot());
> 
> > -               igt_device_drop_master(fd);

Or maybe:
	igt_require(__igt_device_set_master(fd)); /* requires root privilege */
	igt_device_drop_master(fd);
?

To verify we can obtain DRM_MASTER if we wanted it, and assert that we
don't have it for the actual test.
-Chris


More information about the igt-dev mailing list