[igt-dev] [PATCH i-g-t v2] tests/gem_render_copy: Use a more elaborate pattern of pixels

Chris Wilson chris at chris-wilson.co.uk
Tue Jul 3 14:00:12 UTC 2018


Quoting Ville Syrjala (2018-07-03 13:30:22)
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
> Checking whether we can copy solid rectangles isn't particularly
> robust. Eg. errors in texture coordinates/interpolation wouldn't
> necessarily show up at all because all texels are identical.
> 
> Let's switch to a more elaborate pattern that should catch such
> errors. And we'll also change the test to not start the copy
> from position 0,0 in the texture.
> 
> We'll generate the reference image (against which the rendercopy
> results are compared) by peforming an identical copy using the
> cpu.
> 
> v2: Use gtt mmap instead of pread/pwrite (Chris)
>     Offset the dst coordinates by -1,-1 to make sure
>     the copy doesn't go past the intended region
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>

No alarm bells ringing,
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris


More information about the igt-dev mailing list