[igt-dev] [PATCH i-g-t v2 7/7] tests/gem_render_copy: Add a subtest for AUX_CCS_E

[Chris Wilson]

Quoting Ville Syrjala (2018-07-05 19:28:09)
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
> Add a new subtest that does renders the test pattern into a
> compressed buffer. And we'll follow it up with another copy
> back to an uncompressed buffer so that we also test the
> capability to sampled from compressed buffers, and also so
> that we can actually compare the results against the reference
> image.

Ok, so CCS is being carried along in an adjacent image allocated just
after the principle buf. (From the SURFACE_STATE, I expect the HW can
use any address as compressed storage, so this layout is for
convenience? I ask because I was thinking that maybe it would be easier
to have a tiled bo and a separate aux bo.)

We then populate this by doing our render copies into the extended CCS
surface, and check by copying out again (to perform our resolve) into
each of the different target tilings. Therefore we are checking both
source and dest with each tiling mode.

Code looks fine and I'll trust your alignments.
 
> We'll also do a quick check of the aux surface to check that
> it actually indicates that at least some parts of the buffer
> were in fact compressed. Further visual verification can be
> done via the dumped png.
> 
> v2: Test various tiling formats with CCS as well
>     Combine the ccs test into the same function as
>     the rest
>     Pass the correct thing to intel_gen()
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris