[igt-dev] [PATCH i-g-t 04/11] trace.pl: Put single context at single vertical slot

Wed Jul 11 17:55:56 UTC 2018

On 7/9/2018 6:19 AM, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
>
> Turn off timeline stacking in favour of putting all the boxes belonging to
> a single context at the same vertical slot.
>
> Also remove the custom sorting function in favour of correctly assigning
> the subgroup id's and order which greatly speeds up the library operations.
>
> And finally remove the 'Toggle stacking' button which never worked.
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> Cc: John Harrison <John.C.Harrison at Intel.com>
> ---
>   scripts/trace.pl | 25 ++++++-------------------
>   1 file changed, 6 insertions(+), 19 deletions(-)
>
> diff --git a/scripts/trace.pl b/scripts/trace.pl
> index 4d3e06434f05..e2978e5382c2 100755
> --- a/scripts/trace.pl
> +++ b/scripts/trace.pl
> @@ -768,9 +768,6 @@ print <<ENDHTML if $html;
>     <link href="node_modules/vis//dist/vis.css" rel="stylesheet" type="text/css" />
>   </head>
>   <body>
> -
> -<button onclick="toggleStackSubgroups()">Toggle stacking</button>
> -
>   <p>
>   <b>Timeline request view:</b>
>   <table>
> @@ -997,6 +994,7 @@ foreach my $key (sort sortQueue keys %db) {
>   	my $submit = $queue + $db{$key}->{'submit-delay'};
>   	my ($content, $style);
>   	my $group = $engine_start_id + $rings{$db{$key}->{'ring'}};
> +	my $subgroup = $ctx - $min_ctx;

There is no chance that this will cause a problem due to sparse subgroup 
values? E.g. min_ctx is 5 and ctx is 500-510? This change certainly 
makes the charts a lot easier to understand, so it doesn't seem to be an 
issue. But it might be worth checking in the vis documentation if that 
is possible?

Otherwise...

Reviewed-by: John Harrison <John.C.Harrison at Intel.com>