[igt-dev] [PATCH i-g-t] igt/pm_rpm: Pass NULL to require no extra module options

Michał Winiarski michal.winiarski at intel.com
Thu Jul 12 13:38:36 UTC 2018


On Thu, Jul 12, 2018 at 02:32:07PM +0100, Chris Wilson wrote:
> We use options!=NULL to determine if we should require the module to be
> reloaded and fail if we find it already loaded. In pm_rpm, we are only
> ensuring the MSR module is loaded, and only want default options.
> 
> Fixes: 4dc2ce0e ("lib/kmod: Fail if the module is already loaded")
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>

Reviewed-by: Michał Winiarski <michal.winiarski at intel.com>

-Michał

> ---
>  tests/pm_rpm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/pm_rpm.c b/tests/pm_rpm.c
> index 51d8f3661..1f2647be1 100644
> --- a/tests/pm_rpm.c
> +++ b/tests/pm_rpm.c
> @@ -125,7 +125,7 @@ static int8_t *pm_data = NULL;
>  
>  static int modprobe(const char *driver)
>  {
> -	return igt_kmod_load(driver, "");
> +	return igt_kmod_load(driver, NULL);
>  }
>  
>  /* If the read fails, then the machine doesn't support PC8+ residencies. */
> -- 
> 2.18.0
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev


More information about the igt-dev mailing list