[igt-dev] [PATCH i-g-t 5/8] trace.pl: Context save only applies to last request of a bunch

[John Harrison]

On 7/18/2018 2:45 AM, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
>
> Skip accounting the context save time for anything but the last request of
> the coalesced bunch, and also skip drawing those boxes on the timeline.
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> ---
>   scripts/trace.pl | 10 +++++++---
>   1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/scripts/trace.pl b/scripts/trace.pl
> index 575fe83d8550..deb17e4a1816 100755
> --- a/scripts/trace.pl
> +++ b/scripts/trace.pl
> @@ -577,7 +577,11 @@ foreach my $key (@sorted_keys) {
>   	$min_ctx = $db{$key}->{'ctx'} if not defined $min_ctx or
>   					 $db{$key}->{'ctx'} < $min_ctx;
>   
> -	$db{$key}->{'context-complete-delay'} = $end - $notify;
> +	unless (exists $db{$key}->{'no-end'}) {
> +		$db{$key}->{'context-complete-delay'} = $end - $notify;
> +	} else {
> +		$db{$key}->{'context-complete-delay'} = 0;
> +	}
>   	$db{$key}->{'execute-delay'} = $start - $db{$key}->{'submit'};
>   	$db{$key}->{'submit-delay'} = $db{$key}->{'submit'} - $db{$key}->{'queue'};
>   	$db{$key}->{'duration'} = $notify - $start;
> @@ -594,7 +598,7 @@ foreach my $key (@sorted_keys) {
>   
>   	$submit_avg{$ring} += $db{$key}->{'submit-delay'};
>   	$execute_avg{$ring} += $db{$key}->{'execute-delay'};
> -	$ctxsave_avg{$ring} += $end - $notify;
> +	$ctxsave_avg{$ring} += $db{$key}->{'context-complete-delay'};
>   }
>   
>   foreach my $ring (sort keys %batch_avg) {
> @@ -1045,7 +1049,7 @@ foreach my $key (sort sortQueue keys %db) {
>   	}
>   
>   	# user interrupt to context complete
> -	unless (exists $skip_box{'ctxsave'}) {
> +	unless (exists $skip_box{'ctxsave'} or exists $db{$key}->{'no-end'}) {
>   		$skey = -2 * $max_seqno * $ctx - 2 * $seqno;
>   		$style = box_style($ctx, 'ctxsave');
>   		my $ctxsave = $db{$key}->{'end'} - $db{$key}->{'notify'};

Dunno if you missed it but I definitely sent an r-b to this patch in the 
last series. And I can't see any changes since, so...

Reviewed-by: John Harrison <John.C.Harrison at Intel.com>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/igt-dev/attachments/20180718/60775759/attachment-0001.html>