[igt-dev] [PATCH i-g-t v3] tests/perf_pmu: Restore runtime PM at subtest exit

Chris Wilson chris at chris-wilson.co.uk
Fri Jul 20 12:21:39 UTC 2018


Quoting Tvrtko Ursulin (2018-07-20 13:12:22)
> From: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> 
> Restore runtime PM state (via a newly added library function) when the
> test which sets it up exit. This was we avoid running all subsequent sub-
> tests in the aggressive runtime PM mode.
> 
> v2:
>  * Skip double restore. (Chris Wilson)
>  * Close previously leaked fd.
> 
> v3:
>  * Refactor atexit handlers to be signal safe. (Chris Wilson)
>  * Restore audio runtime PM status.
>  * Add a different PCI path to audio device.
> 
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>

(Just ship it already! But I do wonder if there's a better way to find
the control device (search by PCI vendor, class?) and if we shouldn't
make the control/value be uniform in their handling, then just iterate
over the area of (path, value) for restoring.)
-Chris


More information about the igt-dev mailing list