[igt-dev] [PATCH i-g-t v2 4/5] runner: New test runner

Chris Wilson chris at chris-wilson.co.uk
Wed Jul 25 12:41:10 UTC 2018


Quoting Arkadiusz Hiler (2018-07-25 12:56:14)
> On Wed, Jun 13, 2018 at 01:07:38PM +0300, Petri Latvala wrote:
> > +#include "igt_core.h"
> > +#include "executor.h"
> > +#include "output_strings.h"
> > +
> > +struct watchdogs
> 
> I think we can go with static and anonymous struct here to make it more
> obvious that's intended global state.
> 
> > +{

struct { /* no new line, it's not a function */

> > +     int *fds;
> > +     size_t num_dogs;
> > +} watchdogs;
> 
> And maybe an uppercase name?

Around here, uppercase is reserved for macros (though safe
function like macros are allowed to be lower case).
-Chris


More information about the igt-dev mailing list