[igt-dev] [PATCH i-g-t 3/4] lib/igt_color_encoding: Appease c90

Chris Wilson chris at chris-wilson.co.uk
Wed Jun 6 20:42:14 UTC 2018


Quoting Ville Syrjala (2018-06-06 21:16:41)
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
> Apparently we stil build in c90 mode or something with autotools. It
> doesn't like mixed code and declarations.
> 
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
> ---
>  static struct igt_mat4 ycbcr_to_rgb_matrix(const struct color_encoding *e)
>  {
> +       struct igt_mat4 ret = {};
>         float kr, kg, kb;
>  
>         kr = e->kr;

+float kr =...;
>         kb = e->kb;
+float kb = ...;
>         kg = 1.0f - kr - kb;
+float kg = ...;

Would have been the simpler patch :)
-Chris


More information about the igt-dev mailing list