[igt-dev] [PATCH i-g-t v2 1/2] tests/kms_flip: Set duration for subtest from command line

Mika Kahola mika.kahola at intel.com
Wed Jun 13 12:49:59 UTC 2018


On Wed, 2018-06-13 at 13:07 +0100, Chris Wilson wrote:
> Quoting Mika Kahola (2018-06-13 12:30:37)
> > 
> > To reduce the execution time of kms_flip test on CI, let's move
> > subtest
> > duration parameter as command line option. The default subtest
> > duration
> > is 0 seconds meaning that the subtest is run only once.
> > 
> > The patch reduces the kms_flip binary mode execution time on
> > Geminilake from
> > 1189 seconds down to 307 seconds with default subtest duration.
> > 
> > No functional changes on subtests.
> That's a bold claim, since you change the very essence of the test.
> Going from a few commits to one is a big change, a supplementary set
> of
> tests but not a replacement.
What I meant to say by this statement was that I didn't change any
functionality of the subtests itself. The patch introduces a command
line option to set the duration of the subtest instead of hardcoded
one. In that sense, I didn't considered it such a big change as you
still have the option to set the test duration.

> -Chris
-- 
Mika Kahola - Intel OTC



More information about the igt-dev mailing list