[igt-dev] [PATCH i-g-t v2 1/3] lib/rendercopy: Add gen4/5 rendercopy

[Katarzyna Dec]

On Wed, Jun 20, 2018 at 01:54:34PM +0200, Lukasz Kalamarz wrote:
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
> Add rendercopy implementation for gen4/5. Basic structure
> copied from the gen6 implementation, and the gen4/5 specific
> bits were mostly lifted from sna.
> 
> v2: Renamed registers definitions, which are GEN4 specific
> to include that prefix (Lukasz)
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
> Signed-off-by: Lukasz Kalamarz <lukasz.kalamarz at intel.com>
> Cc: Katarzyna Dec <katarzyna.dec at intel.com>
> Cc: Antonio Argenziano <antonio.argenziano at intel.com>
> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>

Generally whole series looks ok. The only note to all 3 patches is
to use checkpatch to check style errors (check it on files, e.g.
checkpatch.pl -f gen4_render.h).
Not all comments from checkpatch should be applied, because not all
make sense in this case.
Some defines are not algined. I have applied all 3 patches and
checked, because looking into *.patch seemed like there is a lot
of them.

Kasia :)