[igt-dev] [PATCH i-g-t v3] meson: Add options to control optional parts

Jani Nikula jani.nikula at linux.intel.com
Thu Jun 28 09:29:27 UTC 2018


On Mon, 25 Jun 2018, Arkadiusz Hiler <arkadiusz.hiler at intel.com> wrote:
> From: Petri Latvala <petri.latvala at intel.com>
>
> Distributions want explicit control over optional parts so they can
> state runtime dependencies before building. Let's restore the
> functionality autotools used to provide.
>
> Where possible, the selection is done by choosing whether to build a
> particular item and the option name is build_$item. Example:
> build_overlay. Where not possible, the option name is
> with_$item. Example: with_valgrind.
>
> Array options require a bump of required meson version to 0.44. Debian
> stable has meson 0.37 which is already too old, stable-backports has
> 0.45, CI uses 0.45. Mesa's meson requirement is 0.44.1, for a
> perspective.

I'm fine with the meson version requirement. However, for some reason
the meson_version : '>0.44.0' doesn't take effect for meson_options.txt:

"""
$ rm -rf build; meson build
The Meson build system
Version: 0.42.1
Source dir: /home/jani/src/intel-gpu-tools
Build dir: /home/jani/src/intel-gpu-tools/build
Build type: native build

Meson encountered an error in file meson_options.txt, line 7, column 0:
Unknown type array.
"""

I can obviously just update meson now that I figured it out, but is
there something we could do to be more helpful for the next person
hitting this?

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Graphics Center


More information about the igt-dev mailing list