[igt-dev] [PATCH i-g-t v5 2/3] tests: add i915 query tests

Tvrtko Ursulin tvrtko.ursulin at linux.intel.com
Thu Mar 8 15:47:01 UTC 2018


On 08/03/2018 14:44, Chris Wilson wrote:
> Quoting Lionel Landwerlin (2018-03-08 14:31:16)
>> On 08/03/18 11:22, Tvrtko Ursulin wrote:
>>> Interesting question how we want to name this test. We don't have any
>>> i915_ prefix tests, but for instance there is drv_getparams_basic,
>>> suggesting this could be called drv_query_ioctl or something?
>>>
>>> Open for discussion I guess.
>>
>> I've been considering renaming perf.c (that's a pretty confusing one...)
>>
>> One could argue that if IGT tests more than intel devices, we should
>> have a driver prefix (I see vc4 has).
> 
> Yes. Move all of the i915.ko specific tests to tests/i915/
> 
> For build system simplicity, I'd advocate keeping generic tests
> separate from driver specific tests. So kms_flip would have kms/ and
> i915/ portions, etc.
> 
> (And tools/i915; benchmarks/i915 etc)

Okay but pencil in for future work I'd suggest since we are working 
against a deadline here. :) At least no need to incorporate larger 
renames like that into this work.

Regards,

Tvrtko


More information about the igt-dev mailing list