[igt-dev] [PATCH i-g-t 2/2] meson: Force libdrm version also for the subpackages

Antonio Argenziano antonio.argenziano at intel.com
Thu Mar 8 18:34:36 UTC 2018



On 08/03/18 03:25, Arkadiusz Hiler wrote:
> libdrm_intel, libdrm_nouveau and libdrm_amdgpu were accepted in any
> version, which caused problems (missing symbols) with more than one
> libdrm present, (e.g. local one for testing and a system-wide one
> provided by the distribution).
> 
> Let's enforce the version everywhere.
> 
> Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler at intel.com>

LGTM but since I have very little meson experience:

Acked-by: Antonio Argenziano <antonio.argenziano at intel.com>

> ---
>   meson.build | 9 +++++----
>   1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/meson.build b/meson.build
> index 6944d026..c4efc19b 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -32,10 +32,11 @@ inc_for_gtkdoc = include_directories('lib')
>   
>   config = configuration_data()
>   
> -libdrm = dependency('libdrm', version : '>=2.4.82')
> -libdrm_intel = dependency('libdrm_intel', required : false)
> -libdrm_nouveau = dependency('libdrm_nouveau', required : false)
> -libdrm_amdgpu = dependency('libdrm_amdgpu', required : false)
> +libdrm_version = '>=2.4.82'
> +libdrm = dependency('libdrm', version : libdrm_version)
> +libdrm_intel = dependency('libdrm_intel', version : libdrm_version, required : false)
> +libdrm_nouveau = dependency('libdrm_nouveau', version : libdrm_version, required : false)
> +libdrm_amdgpu = dependency('libdrm_amdgpu', version : libdrm_version, required : false)
>   
>   pciaccess = dependency('pciaccess', version : '>=0.10')
>   libkmod = dependency('libkmod')
> 


More information about the igt-dev mailing list