[igt-dev] [PATCH i-g-t] tests/pm_rpm: Don't try to create an X-tiled ARGB8888 framebuffer

Ville Syrjala ville.syrjala at linux.intel.com
Fri Mar 9 20:43:08 UTC 2018


From: Ville Syrjälä <ville.syrjala at linux.intel.com>

On most platforms ARGB8888 is only supported by the cursor plane,
which doesn't support tiled buffers. Hence the kernel is under no
obligation to accept the request to create a tiled ARGB888
framebuffer. Apparently we've been letting this slip through so
far, but that is about to change.

Fortunately the resulting fb was neer actually used (in fact the
kernel would have rejected the setplane/atomic ioctl with such
a framebuffer). All we're really interested here is the gem BO
which we feed to the kernel via the setcursor ioctl after changing
the tiling to linear. To avoid changing the test drastically we
can simply change the fb to XRGB8888, which combined with X-tiling
is supported on all platforms.

Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
---
 tests/pm_rpm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/pm_rpm.c b/tests/pm_rpm.c
index 04be8c544826..d2b837fe9255 100644
--- a/tests/pm_rpm.c
+++ b/tests/pm_rpm.c
@@ -1446,7 +1446,7 @@ static void cursor_subtest(bool dpms)
 		      LOCAL_DRM_FORMAT_MOD_NONE, &cursor_fb1);
 	igt_create_fb(drm_fd, 64, 64, DRM_FORMAT_ARGB8888,
 		      LOCAL_DRM_FORMAT_MOD_NONE, &cursor_fb2);
-	igt_create_fb(drm_fd, 64, 64, DRM_FORMAT_ARGB8888,
+	igt_create_fb(drm_fd, 64, 64, DRM_FORMAT_XRGB8888,
 		      LOCAL_I915_FORMAT_MOD_X_TILED, &cursor_fb3);
 
 	fill_igt_fb(&cursor_fb1, 0xFF00FFFF);
-- 
2.16.1



More information about the igt-dev mailing list