[igt-dev] [PATCH i-g-t 2/2] tests/i915_query: split garbage test

[Chris Wilson]

Quoting Lionel Landwerlin (2018-03-13 10:37:18)
> On 13/03/18 09:50, Chris Wilson wrote:
> > Quoting Lionel Landwerlin (2018-03-13 09:17:55)
> >> Unfortunately I forgot that some of those tests require rcs topology
> >> support which we don't have on Sandybridge. This change split the test
> >> in 2 (first part available on all platforms, second part only with rcs
> >> topology support).
> >>
> >> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105475
> >> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
> > Aside, why are the flags prefixed with DRM_I915_QUERY and not just
> > I915_QUERY matching the rest of the uAPI? In fact, the whole perf abi is
> > special. ARGH.
> 
> Argh...
> 
> Is it too late for to send a fix?

Yes. It's been sealed as it has been sent for 4.17 inclusion. From our
perspective, it is upstream already and so now part of the stable ABI.
Changing defines is just as messy as it can cause source code
incompatibility; admittedly that is greatly reduced by our users pulling
in copies of i915_drm.h and so can coordinate the changes. Hmm, but it
still looks ugly and like we are changing uAPI to an outside observer.
 
> Since it's only one DRM_I915_QUERY_TOPOLOGY_INFO, can we add a new 
> define properly named an make the wrongly named one a macro to that?
> And make sure it doesn't happen in the future? (at least for this define)

Nah, what's done is done and we live with it.
-Chris