[igt-dev] [PATCH i-g-t v3] igt/gem_measure_ring_size_inflight: Measure smallest inflight ring size

Arkadiusz Hiler arkadiusz.hiler at intel.com
Tue Mar 27 08:32:16 UTC 2018


On Thu, Mar 22, 2018 at 09:40:44AM -0700, Antonio Argenziano wrote:
> 
> 
> On 21/03/18 14:08, Antonio Argenziano wrote:
> > Some tests measure the render's ring size but are actually meant to
> > measure the smallest across all engines. This patch adds measuring the
> > smallest size in gem_measure_ring_size_inflight() given the appropriate
> > parameter.
> > 
> > v2:
> > 	- Only expose high level API. (Chris)
> > 
> > v3:
> > 	- Use ALL_ENGINES macro.
> > 
> > Suggested-by: Chris Wilson <chris at chris-wilson.co.uk>
> > Signed-off-by: Antonio Argenziano <antonio.argenziano at intel.com>
> > Cc: Chris Wilson <chris at chris-wilson.co.uk>
> > Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk> #2
> 
> @maintainers: Is it OK to merge this patch? I've got a RB on v2 but v3 is
> cosmetic changes plus rebase.

It all reduces to using the common sense.

If this is a change requested by the reviewer and you are sure that's
exactely what was requested, there's no functional changes, and the CI
likes the updated patch - then it's okay to keep the r-b.

If you are not sure, it's better to ping the original reviewer. IRC is
enough.

-- 
Cheers,
Arek


More information about the igt-dev mailing list