[igt-dev] [PATCH i-g-t 05/12] chamelium: Make chamelium_calculate_fb_crc private

[Maxime Ripard]

On Mon, May 14, 2018 at 03:50:33PM +0200, Paul Kocialkowski wrote:
> Hi,
> 
> On Tue, 2018-04-24 at 09:46 +0200, Maxime Ripard wrote:
> > The function chamelium_calculate_fb_crc has no user outside of
> > lib/igt_chamelium.c, but is still part of the global functions exposed in
> > lib/igt_chamelium.h.
> 
> I don't think the fact that it has no immediate user within IGT is a
> reason to move this function out of the public API. Is there a specific
> use case that justifies the need for this?
> 
> The way I see it, chamelium_calculate_fb_crc is simply the synchronous
> version of chamelium_calculate_fb_crc_async and although its use is
> simplified with helpers, I think both functions should be public on the
> same grounds.
> 
> What do you think?

Fair enough :)

This was a spurious attempt at cleaning up, I'm fine either way.

I'll drop this patch.

Maxime

-- 
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/igt-dev/attachments/20180524/4a1d0503/attachment-0001.sig>