[igt-dev] [PATCH i-g-t 2/3] tests/kms_setmode: Request the initial vbl count with RELATIVE instead of ABSOLUTE

Ville Syrjala ville.syrjala at linux.intel.com
Tue Nov 6 16:19:42 UTC 2018


From: Ville Syrjälä <ville.syrjala at linux.intel.com>

Asking for the initial vblank count by specifying and absolute vblank count of 0
doesn't make much sense. Switch to a relative query instead.

It doesn't look like we care about lining up on the first vblank boundary so
we can just drop the NEXTONMISS flag. Only the relative timestamps of the
events will matter.

v2: Drop the NEXTONMISS (Daniel)

Cc: Daniel Vetter <daniel at ffwll.ch>
Cc: Chris Wilson <chris at chris-wilson.co.uk>
Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
---
 tests/kms_setmode.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/kms_setmode.c b/tests/kms_setmode.c
index 681496044f5d..acd606cd5b5e 100644
--- a/tests/kms_setmode.c
+++ b/tests/kms_setmode.c
@@ -434,7 +434,7 @@ static void check_timings(int crtc_idx, const drmModeModeInfo *kmode)
 
 	memset(&wait, 0, sizeof(wait));
 	wait.request.type = kmstest_get_vbl_flag(crtc_idx);
-	wait.request.type |= DRM_VBLANK_ABSOLUTE | DRM_VBLANK_NEXTONMISS;
+	wait.request.type |= DRM_VBLANK_RELATIVE;
 	do_or_die(drmWaitVBlank(drm_fd, &wait));
 
 	last_seq = wait.reply.sequence;
-- 
2.18.1



More information about the igt-dev mailing list