[igt-dev] [Intel-gfx] [PATCH i-g-t] tests/drv_selftest: Allow passing in module options from the command line

[Tvrtko Ursulin]

On 20/11/2018 18:16, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2018-11-20 18:07:57)
>> From: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
>>
>> A new option '--kmod-options' is added which takes a string which will be
>> passed to modprobe when loading the module.
>>
>> This for instance allows easy override of things like the random seed when
>> trying to reproduce failures.
>   
> Anyway we can simply extend the option parsing locally? (Just find it
> unsightly to have test specific options in libigt.)

Well.. it is not test specific but kmod specific but point still stands.

> Stashing argc/argv in igt_subtest_init_parse_opts() and then being able
> to run getopts inside igt_main {}?

Yep, I didn't know we have this already.

> I also had in mind an env for module options, which may be also useful
> for the module reloading and autoloading.

In that case, since modprobe(8) supports MODPROBE_OPTIONS, we could 
perhaps emulate that in igt_kmod? Or add support directly to libkmod? 
With either we wouldn't even need the command line pass through. Adding 
Lucas for an opinion since kmod seems to be his baby.

Regards,

Tvrtko