[igt-dev] [PATCH i-g-t 4/5] lib/kms: warn if we commit without outputs

[Arkadiusz Hiler]

On Thu, Nov 22, 2018 at 10:36:59AM +0100, Daniel Vetter wrote:
> With the high-level helpers requiring outputs there's not point
> in silently ignoring issues anymore. Complain about that if it
> ever happens.
> 
> This reverts
> 
> commit 212b71372bfbb73663d872df31118d6b396ada4f
> Author: Chris Wilson <chris at chris-wilson.co.uk>
> Date:   Fri Sep 14 21:03:38 2018 +0100
> 
>     lib/kms: Skip no-op display updates
> 
> which created an in my opinion serious API issue by silently dropping
> possible errors on the floor. Instead of silently second guess what
> the test might have wanted to do in the absence of display outputs
> it's much better to be explicit, and enforce that.
> 
> v2: Improve commit message.
> 
> v3: Switch to an assert and update comments, to make it clear this is
> igt_display api abuse (Arek).
> 
> Cc: Antonio Argenziano <antonio.argenziano at intel.com>
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Arkadiusz Hiler <arkadiusz.hiler at intel.com>
> Cc: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
> Reviewed-by: Maarten Lankhorst <maarten.lankhorst at linux.intel.com> (v2)
> Signed-off-by: Daniel Vetter <daniel.vetter at intel.com>

Acked-by: Arkadiusz Hiler <arkadiusz.hiler at intel.com>