[igt-dev] [PATCH i-g-t 3/5] lib/kms: Drop igt_display_init

[Daniel Vetter]

On Mon, Nov 26, 2018 at 01:37:03PM -0800, Antonio Argenziano wrote:
> 
> 
> On 22/11/18 01:36, Daniel Vetter wrote:
> > If you need the high-level functions, then you probably need a
> > full display. Unexport the non-requiring version, and adjust the
> > documentation. This also gives us proper docs for the recently
> > added igt_display_require.
> 
> I actually liked having init and require to be separate. Are there no
> negative test cases that might play-around with a failing init?

We dont (yet?) have testcases for the igt_display library itself. For any
kernel tests the summar above explains it: If you want to write
low-level/negative tests of atomic/kms functionality, igt_display is to
high-level to be useful. All those tests use libdrm functions directly
(plus maybe some of the low-level helpers we have, the functions with
kmstest_ prefixes).

> other than that the series LGTM but you might want someone to look at [2/5]
> in details,
> Acked-By: Antonio Argenziano

Thanks for taking a look, I'll pull in the entire series now.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch