[igt-dev] [Intel-gfx] [PATCH i-g-t 1/5] igt/kms_getfb: Check the iface exists before use

Joonas Lahtinen joonas.lahtinen at linux.intel.com
Tue Oct 2 08:30:00 UTC 2018


Quoting Antonio Argenziano (2018-10-01 22:53:46)
> Fair enough.
> 
> Acked-by: Antonio Argenziano <antonio.argenziano at intel.com>
> 
> for the series.

Please, read the following chapters (they're applicable for the patch
tag meanings in IGT, too):

https://www.kernel.org/doc/html/v4.18/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by
https://www.kernel.org/doc/html/v4.18/process/submitting-patches.html#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes

If we spend the time to actually review the patches, that should be
documented with a proper Reviewed-by and not a vague Acked-by.

Regards, Joonas


More information about the igt-dev mailing list