[igt-dev] [PATCH i-g-t 1/1] runner: Add time_elapsed field to results

Petri Latvala petri.latvala at intel.com
Wed Oct 3 10:27:16 UTC 2018


On Wed, Oct 03, 2018 at 12:06:35PM +0300, Arkadiusz Hiler wrote:
> On Thu, Sep 27, 2018 at 04:11:42PM +0300, Petri Latvala wrote:
> > When starting a test run, drop a timestamp file. Do the same when
> > ending a run. Slap those timestamps directly into the time_elapsed
> > field in results.json.
> > 
> > Using timestamps instead of measuring actual elapsed time goes against
> > the naming of the field, but the name is chosen by piglit. Even though
> > piglit itself uses timestamps.
> > 
> > Corner cases:
> > 
> > On incomplete test runs, the end timestamp will be missing. The
> > time_elapsed field will only have the start timestamp. This matches
> > piglit behaviour exactly.
> > 
> > On incomplete but resumed test runs, the end timestamp will be the
> > time when the resume finishes. Piglit doesn't do this, and instead
> > leaves the end timestamp missing. Discussing which behaviour is better
> > is left as an exercise to the readers.
> > 
> > Signed-off-by: Petri Latvala <petri.latvala at intel.com>
> > Cc: Arkadiusz Hiler <arkadiusz.hiler at intel.com>
> > Cc: Tomi Sarvela <tomi.p.sarvela at intel.com>
> 
> Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler at intel.com>
> 
> Once this gets merged we will have to update IGT on the the CI host.

Merged now, thanks.


-- 
Petri Latvala


More information about the igt-dev mailing list