[igt-dev] [PATCH v8 03/16] fb: Add RGB888 format

Arkadiusz Hiler arkadiusz.hiler at intel.com
Fri Oct 5 15:57:01 UTC 2018


On Thu, Oct 04, 2018 at 02:38:56PM +0200, Maxime Ripard wrote:
> The RGB888 format is the one used as the shadow buffer used when a cairo
> surface is requested for a format that Cairo cannot handle.
> 
> Since we're going to move that buffer representation to a struct igt_fb,
> let's add the RGB888 format to the list of formats that igt_fb knows about.
> 
> Signed-off-by: Maxime Ripard <maxime.ripard at bootlin.com>
> ---
>  lib/igt_fb.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/lib/igt_fb.c b/lib/igt_fb.c
> index aaa90bf74a9a..805a7b737981 100644
> --- a/lib/igt_fb.c
> +++ b/lib/igt_fb.c
> @@ -72,6 +72,10 @@ static const struct format_desc_struct {
>  	  .cairo_id = CAIRO_FORMAT_RGB16_565,
>  	  .num_planes = 1, .plane_bpp = { 16, },
>  	},
> +	{ .name = "RGB888", .drm_id = DRM_FORMAT_RGB888,
> +	  .cairo_id = CAIRO_FORMAT_INVALID,
> +	  .num_planes = 1, .plane_bpp = { 24, },
> +	},

We use here the .depth = -1 as a convention.

This should be reworked in tests anyway, so don't bother too much.
I can add it here while applying the series.

Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler at intel.com>


More information about the igt-dev mailing list