[igt-dev] [PATCH i-g-t] tests/kms_frontbuffer_tracking: Do not skip on 4k displays.

[Ville Syrjälä]

On Mon, Oct 15, 2018 at 03:43:38PM +0200, Maarten Lankhorst wrote:
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
> ---
>  tests/kms_frontbuffer_tracking.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/kms_frontbuffer_tracking.c b/tests/kms_frontbuffer_tracking.c
> index 9aecb815024f..bf4a68ff2bde 100644
> --- a/tests/kms_frontbuffer_tracking.c
> +++ b/tests/kms_frontbuffer_tracking.c
> @@ -246,7 +246,7 @@ struct {
>  	.show_hidden= false,
>  	.step = 0,
>  	.only_pipes = PIPE_COUNT,
> -	.shared_fb_x_offset = 500,
> +	.shared_fb_x_offset = 248,

Can't see why 500 would be inherently better than 248. Although I have
to wonder why 248 instead of eg. 256. Magic numbers are just that.

Reviewed-by: Ville Syrjälä <ville.syrjala at linux.intel.com>

>  	.shared_fb_y_offset = 500,
>  	.tiling = LOCAL_I915_FORMAT_MOD_X_TILED,
>  };
> -- 
> 2.19.1
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev

-- 
Ville Syrjälä
Intel