[igt-dev] [PATCH i-g-t 1/3] tests: Rename drv_module_reload to i915_load

Arkadiusz Hiler arkadiusz.hiler at intel.com
Wed Oct 17 16:06:57 UTC 2018


On Wed, Oct 17, 2018 at 04:50:46PM +0100, Chris Wilson wrote:
> Quoting Arkadiusz Hiler (2018-10-17 16:30:13)
> > On Wed, Oct 17, 2018 at 01:34:00PM +0100, Chris Wilson wrote:
> > > Quoting Arkadiusz Hiler (2018-10-17 13:15:43)
> > > > The test is i915 specific, so let's be clear on that. There is also more
> > > > subtests coming that are not just reloading.
> > > 
> > > It's still focussed on module_load, so I would want to keep module in
> > > there so it's clearly nothing to do with runtime loads (workloads).
> > 
> > k
> > 
> > > And adding a 'i915' is a good time to start a i915/
> > 
> > I guess it still makes sense to have the binaries in a single directory,
> > both in build dir and libexec, just prefixed with the folder name.
> > 
> > With meson that's quite easy:
> 
> Seems overkill for 'i915/i915_module_load', and maybe not all i915/
> tests will themselves start with i915_? Just that i915/ is the
> collection of i915 specific tests (like gem_, drv_hangman).
> -Chris

i915/i915_ is an overkill, that why I haven't done that in example.

The file is i915/module_load.c and results in i915_module_load binary.

We should s/drv_// && mv $f i915/.

GEM can be easily handled. Just add a new lists and different prefixing
logic. e.g.:

-------------------------------------------------------------------------------
foreach prog : i915_progs
	test_executables += executable('i915_' + prog, join_paths('i915', prog + '.c'),
		   dependencies : test_deps,
		   install_dir : libexecdir,
		   install_rpath : libexecdir_rpathdir,
		   install : true)
endforeach

foreach prog : gem_progs
	test_executables += executable(prog, join_paths('i915', prog + '.c'),
		   dependencies : test_deps,
		   install_dir : libexecdir,
		   install_rpath : libexecdir_rpathdir,
		   install : true)
endforeach
-------------------------------------------------------------------------------
-Arek


More information about the igt-dev mailing list