[igt-dev] [PATCH i-g-t v4 1/2] lib/debugfs: connector debugfs director

[Chris Wilson]

Quoting Ramalingam C (2018-10-22 15:23:48)
> Function to open a debugfs director of a connector associated to
> a device.
> 
> Signed-off-by: Ramalingam C <ramalingam.c at intel.com>
> ---
>  lib/igt_debugfs.c | 24 ++++++++++++++++++++++++
>  lib/igt_debugfs.h |  1 +
>  2 files changed, 25 insertions(+)
> 
> diff --git a/lib/igt_debugfs.c b/lib/igt_debugfs.c
> index baedc2255ac9..f545e8a3eec9 100644
> --- a/lib/igt_debugfs.c
> +++ b/lib/igt_debugfs.c
> @@ -237,6 +237,30 @@ int igt_debugfs_dir(int device)
>  }
>  
>  /**
> + * igt_debugfs_connector_dir:
> + * @device: fd of the device
> + * @conn_name: conenctor name
> + *
> + * This opens the debugfs directory corresponding to connector on the device
> + * for use with igt_sysfs_get() and related functions.
> + *
> + * Returns:
> + * The directory fd, or -1 on failure.
> + */
> +int igt_debugfs_connector_dir(int device, char *conn_name)
> +{
> +       char path[200], base_path[200];
> +
> +       if (!igt_debugfs_path(device, base_path, sizeof(base_path)))
> +               return -1;

Why not use the debugfs_dir and openat? String ops not required.
-Chris