[igt-dev] [PATCH i-g-t v2] lib/igt_fb: Fix unused variable buf.

Stanislav Lisovskiy stanislav.lisovskiy at intel.com
Fri Oct 26 12:03:05 UTC 2018


Despite the comment temporary buf is not
used anywhere in convert_nv12_to_rgb24,
so it has to be either removed or used instead
of cvt->src.ptr.

v2: Put it in use instead of removing as other
functions seem to use it.

Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy at intel.com>
---
 lib/igt_fb.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/igt_fb.c b/lib/igt_fb.c
index 4700b152..5e775c44 100644
--- a/lib/igt_fb.c
+++ b/lib/igt_fb.c
@@ -1538,8 +1538,8 @@ static void convert_nv12_to_rgb24(struct fb_convert *cvt)
 	 * from there.
 	 */
 	igt_memcpy_from_wc(buf, cvt->src.ptr, cvt->src.fb->size);
-	y = cvt->src.ptr + cvt->src.fb->offsets[0];
-	uv = cvt->src.ptr + cvt->src.fb->offsets[1];
+	y = buf + cvt->src.fb->offsets[0];
+	uv = buf + cvt->src.fb->offsets[1];
 
 	for (i = 0; i < cvt->dst.fb->height / 2; i++) {
 		for (j = 0; j < cvt->dst.fb->width / 2; j++) {
-- 
2.17.1



More information about the igt-dev mailing list