[igt-dev] [PATCH i-g-t] lib: Squelch warning for failing to enable audio powermanagement

Imre Deak imre.deak at intel.com
Tue Sep 4 09:39:50 UTC 2018


On Fri, Aug 31, 2018 at 02:58:28PM +0100, Chris Wilson wrote:
> It doesn't seem to be preventing rpm (see the pm_rpm tests)

Yep, in this case, due to disable_display=1 and so no audio power
domain reference held by snd_hda_intel (no HDMI capable outputs
enumerated by snd_hda_intel). The error itself is due to the
audio init (already after component binding completes, but before
registering the audio device) taking more than our 5 sec polling
time.

Btw, too bad IGT debug log is not shown on the CI results page, even
though there was an error.

> if we fail to enable runtime-powermanagement for audio, so reduce the
> warning to a debug. It will still be visible if it fails, but only if
> it fails.
> 
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Imre Deak <imre.deak at intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin at intel.com>

Reviewed-by: Imre Deak <imre.deak at intel.com>

> ---
>  lib/igt_pm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/igt_pm.c b/lib/igt_pm.c
> index 339a51e6f..b1f359d8b 100644
> --- a/lib/igt_pm.c
> +++ b/lib/igt_pm.c
> @@ -260,7 +260,7 @@ void igt_pm_enable_audio_runtime_pm(void)
>  
>  	err = __igt_pm_enable_audio_runtime_pm();
>  	if (err)
> -		igt_warn("Failed to enable audio runtime PM! (%d)\n", -err);
> +		igt_debug("Failed to enable audio runtime PM! (%d)\n", -err);
>  }
>  
>  /**
> -- 
> 2.19.0.rc1
> 


More information about the igt-dev mailing list