[igt-dev] [PATCH i-g-t] igt/pm_backlight: Skip if pm is not supported

[Ville Syrjälä]

On Wed, Sep 05, 2018 at 10:17:47AM +0100, Chris Wilson wrote:
> If we cannot do runtime suspend, testing it's impact on the backlight is
> moot. Simply skip on systems that cannot runtime suspend.
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107789
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107790
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107794
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> ---
>  tests/pm_backlight.c | 36 +++++++++++++++++++++++++-----------
>  1 file changed, 25 insertions(+), 11 deletions(-)
> 
> diff --git a/tests/pm_backlight.c b/tests/pm_backlight.c
> index 4c0399d46..e94340a2b 100644
> --- a/tests/pm_backlight.c
> +++ b/tests/pm_backlight.c
> @@ -151,23 +151,37 @@ static void test_fade(struct context *context)
>  		nanosleep(&ts, NULL);
>  	}
>  }
> -static void test_fade_with_dpms(struct context *context, igt_output_t *output)
> +
> +static void
> +test_fade_with_dpms(struct context *context, igt_output_t *output)
>  {
> -	bool has_runtime_pm;
> -	has_runtime_pm = igt_setup_runtime_pm();
> -	igt_info("Runtime PM support: %d\n", has_runtime_pm);
> -	igt_assert(has_runtime_pm);
> -	kmstest_set_connector_dpms(output->display->drm_fd, output->config.connector, DRM_MODE_DPMS_OFF);
> -	igt_assert(igt_wait_for_pm_status(IGT_RUNTIME_PM_STATUS_SUSPENDED));
> -	kmstest_set_connector_dpms(output->display->drm_fd, output->config.connector, DRM_MODE_DPMS_ON);
> +	igt_require(igt_setup_runtime_pm());
> +
> +	kmstest_set_connector_dpms(output->display->drm_fd,
> +				   output->config.connector,
> +				   DRM_MODE_DPMS_OFF);
> +	igt_require(igt_wait_for_pm_status(IGT_RUNTIME_PM_STATUS_SUSPENDED));

Should this stays as igt_assert() or is the earlier
igt_require(igt_setup_runtime_pm()) not good enough to
detect that runtime PM is supported?

> +
> +	kmstest_set_connector_dpms(output->display->drm_fd,
> +				   output->config.connector,
> +				   DRM_MODE_DPMS_ON);
>  	igt_assert(igt_wait_for_pm_status(IGT_RUNTIME_PM_STATUS_ACTIVE));
> +
>  	test_fade(context);
>  }
> -static void test_fade_with_suspend(struct context *context, igt_output_t *output)
> +
> +static void
> +test_fade_with_suspend(struct context *context, igt_output_t *output)
>  {
> -	kmstest_set_connector_dpms(output->display->drm_fd, output->config.connector, DRM_MODE_DPMS_OFF);
> -	igt_assert(igt_wait_for_pm_status(IGT_RUNTIME_PM_STATUS_SUSPENDED));
> +	igt_require(igt_setup_runtime_pm());
> +
> +	kmstest_set_connector_dpms(output->display->drm_fd,
> +				   output->config.connector,
> +				   DRM_MODE_DPMS_OFF);
> +	igt_require(igt_wait_for_pm_status(IGT_RUNTIME_PM_STATUS_SUSPENDED));
> +
>  	igt_system_suspend_autoresume(SUSPEND_STATE_MEM, SUSPEND_TEST_NONE);
> +
>  	test_fade(context);
>  }
>  
> -- 
> 2.19.0.rc1
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev

-- 
Ville Syrjälä
Intel