[igt-dev] [PATCH i-g-t] tests/gem_ctx_isoation: Add warn for newer gens.

Chris Wilson chris at chris-wilson.co.uk
Thu Sep 6 20:03:48 UTC 2018


Quoting Antonio Argenziano (2018-09-06 20:59:57)
> Add a warning to update test if GEN version is not recognized.
> 
> Signed-off-by: Antonio Argenziano <antonio.argenziano at intel.com>
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> ---
>  tests/gem_ctx_isolation.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/gem_ctx_isolation.c b/tests/gem_ctx_isolation.c
> index 4325e1c2..bd07b141 100644
> --- a/tests/gem_ctx_isolation.c
> +++ b/tests/gem_ctx_isolation.c
> @@ -700,7 +700,9 @@ igt_main
>                 igt_require(has_context_isolation);
>  
>                 gen = intel_gen(intel_get_drm_devid(fd));
> -               //igt_ci_fail_on(gen > LAST_KNOWN_GEN);
> +
> +               igt_warn_on_f(gen > LAST_KNOWN_GEN,
> +                               "GEN not recognized! Test needs to be updated to run.");
>                 igt_skip_on(gen > LAST_KNOWN_GEN);

Unquestionably an improvement,
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>

Remember to :set cino=:0,(0 though, i.e. continuation lines should be
indented to the bracket.
-Chris


More information about the igt-dev mailing list