[igt-dev] [PATCH i-g-t 2/3] lib/igt_fb: Don't use blitter for large buffers

Chris Wilson chris at chris-wilson.co.uk
Mon Sep 10 15:45:52 UTC 2018


Quoting Ville Syrjala (2018-09-10 16:34:06)
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
> The blitter stride is limited to <32k. Fall back to gtt mmap if we're
> about to exceed that.

True. I was going to say that fb->tiling implied you could use 128k, but
realised that you wanted to blit to linear. A comment would have saved a
moment's confusion/objection.
 
> This won't work for Yf as the fence doesn't know about Yf. So for that
> case we'd need to use cpu mmap and (de)tile manually. For now just
> pretend that there is no problem.

Throw in a warning? If it doesn't cause the test to fail, our test
didn't need all those pixels :)

Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris


More information about the igt-dev mailing list