[igt-dev] [PATCH i-g-t 1/2] runner/resultgen: More checking if subtests should exist
Petri Latvala
petri.latvala at intel.com
Tue Sep 11 11:38:52 UTC 2018
If a test with subtests just exits immediately, or the test binary
doesn't exist at all (as is sometimes the case with kms_chamelium),
the existence of subtests doesn't end up in the execution journal. As
was done for timeouts in a797cbf6918a ("runner/resultgen: Be more
robust with incomplete tests"), check if we were attempting to run a
subtest before attributing a 'notrun' result to an incorrect field.
Signed-off-by: Petri Latvala <petri.latvala at intel.com>
Cc: Arkadiusz Hiler <arkadiusz.hiler at intel.com>
Cc: Martin Peres <martin.peres at linux.intel.com>
---
runner/resultgen.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/runner/resultgen.c b/runner/resultgen.c
index ea680914..d939583d 100644
--- a/runner/resultgen.c
+++ b/runner/resultgen.c
@@ -778,7 +778,7 @@ static void fill_from_journal(int fd,
add_runtime(obj, time);
/* If no subtests, the test result node also gets the runtime */
- if (subtests->size == 0) {
+ if (subtests->size == 0 && entry->subtest_count == 0) {
obj = get_or_create_json_object(tests, piglit_name);
add_runtime(obj, time);
}
--
2.14.1
More information about the igt-dev
mailing list