[igt-dev] [PATCH i-g-t 1/1] runner: Increase buffer size for reading outputs

Arkadiusz Hiler arkadiusz.hiler at intel.com
Fri Sep 14 11:31:07 UTC 2018


On Fri, Sep 14, 2018 at 02:21:39PM +0300, Petri Latvala wrote:
> The law of chosen magic numbers: The number selected is wrong.
> 
> Chose another magic number for the size of the buffer used to read
> test outputs and kernel log records. It's now 2048, up from 256. Also
> added a warning print if that's still not enough for kernel logs.
> 
> The lesson to learn here is that the /dev/kmsg interface does not give
> you a truncated log record as initially thought, but reports an
> undocumented EINVAL instead. Subsequent reads give the next record, so
> the failsafe added will make sure any future EINVALs will only drop
> the record that is too long instead of everything from that point
> onwards.
> 
> Signed-off-by: Petri Latvala <petri.latvala at intel.com>
Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler at intel.com>

Are you also cooking a patch for the kernel docs, to document this
undocumented behavior?

-- 
Cheers,
Arek


More information about the igt-dev mailing list