[igt-dev] [PATCH i-g-t 2/2] lib/gpgpu_fill: Implement gpgpu_fillfunc for Gen11

[Joonas Lahtinen]

Quoting Rodrigo Vivi (2018-09-27 02:57:01)
> On Wed, Sep 19, 2018 at 09:24:11AM +0200, Katarzyna Dec wrote:
> > On Tue, Sep 18, 2018 at 12:30:44PM -0700, José Roberto de Souza wrote:
> > > From: Katarzyna Dec <katarzyna.dec at intel.com>
> > > 
> > > Added gen11_gpgpu_fillfunc to have gpgpu_fill passing on Gen11.
> > > 
> > > Gpgpu shader was generated using IGA (Intel Graphics Assembler)
> > > based on binary found in lib/gpgpu_fill.c to match the
> > > changes in Gen11 HW:
> > > Changed 'mul' instruction to 'shl' (since Gen11 'mul' does
> > > not support integer values for both src and dest).
> > > Changed SEND message descriptor (it should have length 2 not 3).
> > > 
> > > Cc: Lukasz Kalamarz <lukasz.kalamarz at intel.com>
> > > Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
> > > Tested-by: José Roberto de Souza <jose.souza at intel.com>
> > > Signed-off-by: Katarzyna Dec <katarzyna.dec at intel.com>
> > > Signed-off-by: Lukasz Kalamarz <lukasz.kalamarz at intel.com>
> > 
> > Acked-by: Katarzyna Dec <katarzyna.dec at intel.com>
> > Kasia :)

I'm fairly sure the addition of the source code and compiling
instructions was brought up in the early review of the series.

Any reason not following through with it?

Regards, Joonas