[igt-dev] [PATCH i-g-t] tests/kms_plane: Fix crop test

[Daniel Vetter]

On Mon, Apr 01, 2019 at 06:17:07PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
> Set the src/dst viewports correctly when trying to crop off the
> edges.
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110296
> Fixes: 80eb61459791 ("tests/kms_plane: Remove the upscaling requirement")
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>

Oops, bad review by me :-/

Reviewed-by: Daniel Vetter <daniel.vetter at ffwll.ch>

... but not sure how much value there is in that ...
-Daniel

> ---
>  tests/kms_plane.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/kms_plane.c b/tests/kms_plane.c
> index 33e2905a8d71..471bcbeb8f77 100644
> --- a/tests/kms_plane.c
> +++ b/tests/kms_plane.c
> @@ -436,8 +436,11 @@ static void test_format_plane_color(data_t *data, enum pipe pipe,
>  	/*
>  	 * if clamping test. DRM_FORMAT_XRGB8888 is used for reference color.
>  	 */
> -	if (data->crop != 0 && format != DRM_FORMAT_XRGB8888)
> +	if (data->crop != 0 && format != DRM_FORMAT_XRGB8888) {
>  		igt_fb_set_position(fb, plane, data->crop, data->crop);
> +		igt_fb_set_size(fb, plane, width, height);
> +		igt_plane_set_size(plane, width, height);
> +	}
>  
>  	igt_display_commit2(&data->display, data->display.is_atomic ? COMMIT_ATOMIC : COMMIT_UNIVERSAL);
>  	igt_pipe_crc_get_current(data->display.drm_fd, data->pipe_crc, crc);
> -- 
> 2.19.2
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch